Skip to content

Iss 1297#1304

Open
N-Plx wants to merge 6 commits into
developmentfrom
iss-1297
Open

Iss 1297#1304
N-Plx wants to merge 6 commits into
developmentfrom
iss-1297

Conversation

@N-Plx

@N-Plx N-Plx commented Jun 4, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

N-Plx and others added 5 commits June 4, 2026 10:24
@N-Plx @baltzell
merge dev into iss-1297 (#1303)
8205106 
* avoid listeners and timers and call event action manually (#1301)

* remove unused wrapper class (#1296)

---------

Co-authored-by: Nathan Baltzell <baltzell@gmx.com>
@N-Plx
run-dependent slope correction (radiation damage t0 increase) and som…
cb4bb37 
…e cleanup
@N-Plx
Merge branch 'development' into iss-1297
06501da
@N-Plx
run propagation from the engine to the hits
75314fd
@N-Plx
solving merge issue
7236af3
@N-Plx

N-Plx commented Jun 4, 2026

Copy link
Copy Markdown
Collaborator Author

ATOF calibrations to correct for the radiation damage effects that increases time offsets with time. It’s the slope that we see in these timelines:

image

This slope is corrected per blocks of runs, as it varies in different periods. A timing correction is defined as dt = (run number-reference run)*slope. This means that we need to know the run number for each hit to compute the full-time correction. Run number is read out at the engine level and propagated to the hits.

@baltzell

baltzell commented Jun 5, 2026

Copy link
Copy Markdown
Collaborator

code.jlab.org had issues yesterday, hence the git-lfs errors in the CI jobs. Should be resolved as of this morning.

@baltzell baltzell added the rg-l label Jun 5, 2026
@N-Plx N-Plx marked this pull request as ready for review June 8, 2026 21:51
@N-Plx

N-Plx commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator Author

Zhiwan's validation of the timing corrections shows the offsets are now well corrected for:
image

@mathieuouillon

mathieuouillon commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator

Looks good to me! The only thing I'd consider is building the key from (sector, layer, component, order) once and reusing it across the four getDoubleValue calls on lines 207/8 in reconstruction/alert/src/main/java/org/jlab/rec/atof/hit/ATOFHit.java (), since they all share the same keys. It's an optimization, though, so only worth it if this path is hot. So feel free to take it or leave it.

Minor nit: Run is capitalized for a field/parameter, which goes against the usual Java convention (run).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@baltzell baltzell Awaiting requested review from baltzell baltzell is a code owner

@mathieuouillon mathieuouillon Awaiting requested review from mathieuouillon mathieuouillon is a code owner

@mpaolone mpaolone Awaiting requested review from mpaolone mpaolone is a code owner

@efuchey efuchey Awaiting requested review from efuchey efuchey is a code owner

@whit2333 whit2333 Awaiting requested review from whit2333 whit2333 is a code owner

@ftouchte ftouchte Awaiting requested review from ftouchte ftouchte is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

rg-l

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@N-Plx @baltzell @mathieuouillon